remove commented block in xml ruby

Question

I'm required to write a script that can remove a commented block in xml file, and save it back to its directory.

    <Configure id="Server" class="org.eclipse.jetty.server.Server">

    <!-- =========================================================== -->
    <!-- Server Thread Pool                                          -->
    <!-- =========================================================== -->
    <Set name="ThreadPool">
      <!-- Default queued blocking threadpool -->
      <New class="org.eclipse.jetty.util.thread.QueuedThreadPool">
        <Set name="minThreads">10</Set>
        <Set name="maxThreads">10000</Set>
        <Set name="detailedDump">false</Set>
      </New>
    </Set>

    <!-- =========================================================== -->
    <!-- Set connectors                                              -->
    <!-- =========================================================== -->

      <!--
        <Call name="addConnector">
          <Arg>
              <New class="org.eclipse.jetty.server.nio.SelectChannelConnector">
                <Set name="host"><SystemProperty name="jetty.host" /></Set>
                <Set name="port"><SystemProperty name="jetty.port" default="8983"/></Set>
                <Set name="maxIdleTime">50000</Set>
                <Set name="Acceptors">2</Set>
                <Set name="statsOn">false</Set>
                <Set name="confidentialPort">8443</Set>
          <Set name="lowResourcesConnections">5000</Set>
          <Set name="lowResourcesMaxIdleTime">5000</Set>
              </New>
          </Arg>
        </Call>
      -->        
    <Call name="addConnector">
  <Arg>
      <New class="org.eclipse.jetty.server.bio.SocketConnector">
        <Set name="host"><SystemProperty name="jetty.host" /></Set>
        <Set name="port"><SystemProperty name="jetty.port" default="8983"/></Set>
        <Set name="maxIdleTime">50000</Set>
        <Set name="lowResourceMaxIdleTime">1500</Set>
        <Set name="statsOn">false</Set>
      </New>
  </Arg>
</Call>

    </Configure>

on this xml How can I comment out this block only?

<!--
   <Call name="addConnector">
      <Arg>
       <New class="org.eclipse.jetty.server.nio.SelectChannelConnector">
         <Set name="host"><SystemProperty name="jetty.host" /></Set>
         <Set name="port"><SystemProperty name="jetty.port" default="8983"/></Set>
         <Set name="maxIdleTime">50000</Set>
         <Set name="Acceptors">2</Set>
         <Set name="statsOn">false</Set>
         <Set name="confidentialPort">8443</Set>
         <Set name="lowResourcesConnections">5000</Set>
         <Set name="lowResourcesMaxIdleTime">5000</Set>
      </New>
    </Arg>
  </Call>
 -->

I have tried it with this but

  require 'nokogiri'

file = File.read("jetty.xml")
xml = Nokogiri::XML(file)

#replace <!-- --> with a space 
xml.xpath("//comment()").each do |node|
    node.content =node.content.gsub!(/(^\D\W[<!\-\-}]\W[\-\->])/,' ')
end

File.open("newjetty.xml","w") do |f|
    f.write xml.to_xml
end

this code only remove the text within the comment

Output:

     <!---->
        <!---->
        <!---->


 <Set name="ThreadPool">
      <!---->
      <New class="org.eclipse.jetty.util.thread.QueuedThreadPool">
        <Set name="minThreads">10</Set>
        <Set name="maxThreads">10000</Set>
        <Set name="detailedDump">false</Set>
      </New>
    </Set>

        <!---->
        <!---->
        <!---->

      <!---->

        <!---->

If you stuck to Nokogiri, you’d likely try to store node.content, then delete the entire comment node and add node.content there. — Aleksei Matiushkin
– Aleksei Matiushkin, Commented Jul 24, 2014 at 10:00
mudasobwa can you please give an example, I did use node.content — user3635322
– user3635322, Commented Jul 24, 2014 at 10:08

dirkk · Accepted Answer · 2014-07-24 10:39:46Z

1

You should delete the node, as it is a comment node. You can use the inner text to parse it and add it again.

require 'nokogiri'

file = File.read("jetty.xml")
xml = Nokogiri::XML(file)

#replace <!-- --> with a space 
xml.xpath("//comment()").each do |node|
    t = Nokogiri::XML::DocumentFragment.parse(node.content)
    node.add_next_sibling(t)
    node.remove
end

File.open("newjetty.xml","w") do |f|
    f.write xml.to_xml
end

Here you are parsing the comments content, add it as the next sibling and remove the node itself.

This basically works, however the string-only contents are also added as nodes, making this a mixed content document, which you most certainly do not want for a jetty configuration file.

So there should also be some logic included that checks for the node type (text versus element) and only includes elements.

answered Jul 24, 2014 at 10:39

dirkk

6,2285 gold badges35 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

user3635322 Over a year ago

are comments referred as node in xml?

dirkk Over a year ago

Yes, comment is a node type

user3635322 Over a year ago

so does that mean a node returns a list of node types?

dirkk Over a year ago

I don't know what you mean by that. How can a node (being an object) return anything? Also, I have no knowledge of Ruby (this was my first ruby snippet ever, I think), so I am really of no help at all if you ask specific stuff about ruby or nokogiri.

user3635322 Over a year ago

i was asking with regard to the code snippet you gave me, it doesn't work when i run my script. thanks for your help

|

Collectives™ on Stack Overflow

remove commented block in xml ruby

1 Answer 1

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related