Getting "syntax error near unexpected token `fi'" in my bash script

Question

I'm pretty sure I have an issue with my syntax. I've made a simple if/ifthen script, but it hasn't executed. I can't find anything online about it, because I don't know exactly what the issue is.

After fixing most of the problems I'm left with this output:

/media/satahd/media/test.sh: line 21: syntax error near unexpected token `fi'
/media/satahd/media/test.sh: line 21: `fi'

here's the script:

#!/bin/bash

###root symlink folder:
rootmedia='/media/satahd/media/slinktest'

###root donwload folder:
rootdownload='/media/satahd/media/downloads'
TR_TORRENT_NAME=$1
TR_TORRENT_DIR=$2

anime=$rootdownload'/anime'
movie=$rootdownload'/movies'
western=$rootdownload'/western'

if [ $TR_TORRENT_DIR == $anime ] then
    filebot --action symlink --conflict skip --db AniDB --format "{n} ({y})/{n} {s00e00} {t}({group} {vf})" -r -rename $anime/$TR_TORRENT_NAME non-strict --output $rootmedia/Shows/Anime --order absolute
elseif [ $TR_TORRENT_DIR == $movie ] then
    filebot --action symlink --conflict skip --db themoviedb --format "{n} ({y})/{n} ({y}) {group} {vc}-{vf} {ac}-{af}" -r -rename $movie/$TR_TORRENT_NAME -non-strict --output $rootmedia/Movies
elseif [ $TR_TORRENT_DIR == $western ] then
    filebot --action symlink --conflict skip --db thetvdb --format "{n} ({y})/{n} {s00e00} {t}({group} {vf})" -r -rename $western/$TR_TORRENT_NAME non-strict --output $rootmedia/Shows/Western --order absolute
fi

clearlight · Accepted Answer · 2015-04-03 01:09:54Z

5

Why don't you try using elif, not elseif.

Also put a ; before the then.

When you put then on the same line as the if, you need the ; delimiter. You don't need it if then is on the next line.

Same thing with for *condition* ; do If do is on the same line as for, you need the ; otherwise you don't.

This might work better for you, I corrected just the things I mentioned, but obviously it would be something I couldn't easily test myself.

#!/bin/bash

###root symlink folder:
rootmedia='/media/satahd/media/slinktest'

###root donwload folder:
rootdownload='/media/satahd/media/downloads'
TR_TORRENT_NAME=$1
TR_TORRENT_DIR=$2

anime=$rootdownload'/anime'
movie=$rootdownload'/movies'
western=$rootdownload'/western'

if [ $TR_TORRENT_DIR == $anime ]; then
    filebot --action symlink --conflict skip --db AniDB --format "{n} ({y})/{n} {s00e00} {t}({group} {vf})" -r -rename $anime/$TR_TORRENT_NAME non-strict --output $rootmedia/Shows/Anime --order absolute
elif [ $TR_TORRENT_DIR == $movie ]; then
    filebot --action symlink --conflict skip --db themoviedb --format "{n} ({y})/{n} ({y}) {group} {vc}-{vf} {ac}-{af}" -r -rename $movie/$TR_TORRENT_NAME -non-strict --output $rootmedia/Movies
elif [ $TR_TORRENT_DIR == $western ]; then
    filebot --action symlink --conflict skip --db thetvdb --format "{n} ({y})/{n} {s00e00} {t}({group} {vf})" -r -rename $western/$TR_TORRENT_NAME non-strict --output $rootmedia/Shows/Western --order absolute
fi

edited Apr 3, 2015 at 1:09

answered Apr 3, 2015 at 0:53

clearlight

12.7k11 gold badges61 silver badges82 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

greasysock Over a year ago

thanks! a lot of the articles online were really unclear, this helped a lot!

clearlight Over a year ago

sh and bash are kind of awkward and ugly. Almost wish ruby was the standard scripting language on OSes 8-}

Ashish Srivastava · Accepted Answer · 2015-04-05 19:51:01Z

3

you can check your script for these type of errors at

http://www.shellcheck.net/

i generally use this for spotting my errors.

answered Apr 5, 2015 at 19:51

Ashish Srivastava

1016 bronze badges

Collectives™ on Stack Overflow

Getting "syntax error near unexpected token `fi'" in my bash script

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related